Global field #26

rohitmishra209 · 2020-03-31T09:23:42Z

No description provided.

config/default.js

ninadhatkar · 2020-04-01T07:25:42Z

config/index.js

@@ -9,5 +9,5 @@ module.exports = {
  password: '',
  target_stack: '',
  // Folder in which exported contents are stored
-  data: './contents'
+  data: './New-data'


Can you verify this?

ninadhatkar

Missing dependencies

chalk: ./lib/util/login.js
Resolve linting issues.

ninadhatkar · 2020-04-01T08:24:56Z

lib/import/content_types.js

+    var self = this;
+    return new Promise(function(resolve, reject) {
+      return Promise.map(_globalField_pending, function (globalfield) {
+        var lenglobalfield = (self.globalfields).length;


lenglobalfield >> lenGlobaField

ninadhatkar · 2020-04-01T08:29:09Z

lib/import/content_types.js

+              // console.log("dattatatat", _globalField_pending);
+              if(error.error_code === 115) {
+                // eslint-disable-next-line no-console
+                log.error('globalfield fail to import '+ JSON.stringify(error.errors));  


Re-check what error message we can add here

ninadhatkar · 2020-04-01T09:03:33Z

lib/import/content_types.js

@@ -18,8 +18,12 @@ var supress = require('../util/extensionsUidReplace');
 var config = util.getConfig();

 var contentTypeConfig = config.modules.content_types;
+var globalfieldsConfig = config.modules.globalfields;


Follow naming conventions for global fields as we follow for content types
e.g.
globalFieldsConfig >> globalFiledConfig (Revmoed 's' and used capital for F) Follow this pattern for all the variables for global filed
updateGlobalFiled

ninadhatkar · 2020-04-01T09:04:10Z

lib/import/content_types.js

+              }
+            };
+            return request(requestGlobalfieldOptions).then(function (response) {
+              // console.log("globalfieldsuid", response.body.global_field.uid);


remove unwanted console logs

ninadhatkar · 2020-04-01T09:06:36Z

lib/import/content_types.js

+          }
+        }
+      }, {
+        concurrency: 3


Make this concurrency configurable from config

ninadhatkar · 2020-04-01T09:07:18Z

lib/import/entries.js

@@ -190,6 +190,9 @@ importEntries.prototype = {
                        return resolve();
                    }
                    for (var eUid in entries) {
+                        // console.log("self contentstypess>>>", self.ctSchemas[ctUid])


Remove comments if not required

ninadhatkar · 2020-04-01T10:19:32Z

lib/import/global_fields.js

            if(error.error_code === 115) {
              // eslint-disable-next-line no-console
-              log.error('Globalfield fail to import '+ JSON.stringify(error.errors));  
+              log.error('globalfield fail to import '+ JSON.stringify(error.errors));  


Suggestion for log 'Global Field: Failed to import due to: ' + JSON.stringify(error.errors)

Have done because all other messages are in small cases the error log.

ninadhatkar · 2020-04-01T10:26:53Z

lib/util/lookupReplaceAssets.js

@@ -26,6 +26,7 @@ module.exports = function (data, mappedAssetUids, mappedAssetUrls, assetUidMappe
  var matchedUrls = [];

  var find = function (schema, entry) {
+   // console.log("findingggg", schema);


remove unused comments

ninadhatkar · 2020-04-02T05:27:26Z

lib/import/content_types.js

-                log.error('globalfield fail to import '+ JSON.stringify(error.errors));  
-              }
+              // eslint-disable-next-line no-console
+              log.error('Globalfield fail to import '+ JSON.stringify(error.errors));  


ninadhatkar · 2020-04-02T05:28:13Z

lib/import/content_types.js

              return;
            });
          }
        }
      }, {
-        concurrency: 3
+        concurrency: concurrencyNo


Only concurrency works

ninadhatkar · 2020-04-02T05:29:13Z

lib/import/content_types.js

@@ -17,9 +17,10 @@ var log = require('../util/log');
 var supress = require('../util/extensionsUidReplace');
 var config = util.getConfig();

+var concurrencyNo = config.concurrency;


change var name to concurrency

change to reqConcurrency

ninadhatkar · 2020-04-02T05:31:24Z

lib/import/environments.js

+            if(error.errors.name[0]) {
+              log.success('Environment: \'' + env.name + '\' already exists');
+            } else {
+              log.error('Environment: \'' + env.name + '\' failed to be imported\n ' + JSON.stringify(error.errors)); 


imported >> import

ninadhatkar · 2020-04-02T05:31:53Z

lib/import/global_fields.js

+            if(error.errors.title[0]) {
+              log.error('Globalfield already exists ');  
+            } else {
+              log.error('Globalfield fail to import '+ JSON.stringify(error.errors));


fail >> failed

ninadhatkar · 2020-04-02T06:55:57Z

lib/import/global_fields.js

-              // eslint-disable-next-line no-console
-              log.error('globalfield fail to import '+ JSON.stringify(error.errors));  
+            if(error.errors.title[0]) {
+              log.error('Globalfield already exists ');  


Add global field details in error logs

ninadhatkar · 2020-04-16T07:26:59Z

config/default.js

  // pass locale, only to migrate entries from that locale
  // not passing `locale` will migrate all the locales present
  // locales: ['fr-fr'],
-  host: 'https://api.contentstack.io/v3',
+  host: 'https://api.contentstack.com/v3',


Verify this

rohitmishra209 · 2020-04-17T14:01:48Z

Now you can use Global fields as blocks of a Modular Blocks field and add them within the Group field. You can also add Modular Blocks, Group, and Reference fields to the Global field schema

rohitmishra209 added 3 commits March 31, 2020 11:14

Added new feature in global field

bda569b

Added feature under globalfield

1ef89f3

Added feature under globalfield

69f10fa

ninadhatkar reviewed Apr 1, 2020

View reviewed changes

config/default.js Outdated Show resolved Hide resolved

ninadhatkar reviewed Apr 1, 2020

View reviewed changes

ninadhatkar suggested changes Apr 1, 2020

View reviewed changes

rohitmishra209 added 2 commits April 1, 2020 20:03

removed unwanted code

2138491

made changes for concurrency

814e918

ninadhatkar suggested changes Apr 2, 2020

View reviewed changes

rohitmishra209 added 2 commits April 4, 2020 13:44

resolve the bug of reference under global field

0b46024

solved the bug of reference under group and moduler block

ec36a89

ninadhatkar suggested changes Apr 16, 2020

View reviewed changes

rohitmishra209 added 6 commits April 16, 2020 14:32

updated in global-field module

ec8fb35

updated in global-field module

a1f7000

solve bugs on globalfield

7b4df90

solve bugs on globalfield

98afcf5

removed unwanted code

ca88fbb

Merge branch 'master' into globalField

452858d

rohitmishra209 merged commit 8be30c0 into master Apr 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Global field #26

Global field #26

rohitmishra209 commented Mar 31, 2020

ninadhatkar Apr 1, 2020

ninadhatkar left a comment

ninadhatkar Apr 1, 2020 •

edited

Loading

ninadhatkar Apr 1, 2020

ninadhatkar Apr 1, 2020 •

edited

Loading

ninadhatkar Apr 1, 2020

ninadhatkar Apr 1, 2020

ninadhatkar Apr 1, 2020

ninadhatkar Apr 1, 2020

rohitmishra209 Apr 1, 2020

ninadhatkar Apr 1, 2020

rohitmishra209 Apr 16, 2020

ninadhatkar Apr 2, 2020

rohitmishra209 Apr 16, 2020

ninadhatkar Apr 2, 2020

ninadhatkar Apr 2, 2020

rohitmishra209 Apr 16, 2020 •

edited

Loading

ninadhatkar Apr 2, 2020

rohitmishra209 Apr 16, 2020

ninadhatkar Apr 2, 2020

ninadhatkar Apr 2, 2020

ninadhatkar Apr 16, 2020

rohitmishra209 commented Apr 17, 2020

Global field #26

Global field #26

Conversation

rohitmishra209 commented Mar 31, 2020

Choose a reason for hiding this comment

ninadhatkar left a comment

Choose a reason for hiding this comment

ninadhatkar Apr 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ninadhatkar Apr 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rohitmishra209 Apr 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rohitmishra209 commented Apr 17, 2020

ninadhatkar Apr 1, 2020 •

edited

Loading

ninadhatkar Apr 1, 2020 •

edited

Loading

rohitmishra209 Apr 16, 2020 •

edited

Loading