-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github stars based readme extraction and embedding #1
base: main
Are you sure you want to change the base?
Conversation
@nps1ngh please feel free to directly push your commits to this branch directly. |
|
||
from acad_gpt.parsers.base_parser import BaseParser | ||
from acad_gpt.parsers.config import GitHubMDParserConfig | ||
from acad_gpt.utils.github_md_parser_utils import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should keep this contained within a single module and not separate them out as utilities. What do you say? @shahrukhx01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, please feel free to move things around. I’m quite open to changes in this module
repos = [] | ||
|
||
while True: | ||
response = requests.get(f"{GITHUB_API_URL}/users/{github_username}/starred?page={page}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does PyGithub
not have anything for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nps1ngh i believe it does but then you’ve to do the hassle getting a authtoken. However, with this we hit the rate limit quite rapidly. Would you like to take a look at PyGithub then?
Adds the following features: