feat: multiple file scan support #106
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back to draft as there's some big ol race condition issues |
The change to have multi-file scanning done async was causing bad race conditions. It was crashing with the following: `fatal error: concurrent map read and map write` And a lot of goroutine stack traces. After some investigation the old versions can have a goroutine crash if you pretty much DOS it but with the previous change it would crash very quickly. I tried go's `--race` feature but it couldn't find the issue. Adding additional debug logging didn't really help either. Synchronous is good enough here as this is just for the local scan. We can investigate this more indepth another time.
The changes made meant that it could return null rather than an error. The original behavior isn't ideal as a not particularly fatal issue of having a single empty file in multiple provided causes the whole thing to stop and return an error. It'll probably take a breaking change to return the results + an error with a log. Or just looking at some existing error output structures from kubeval and making it similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now provide several files to
kubesec scanto be validated.Resolves #103