Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test GHA #554

Closed
Closed

Conversation

spiarh
Copy link
Contributor

@spiarh spiarh commented Nov 17, 2023

No description provided.

@spiarh spiarh closed this Nov 17, 2023
@06kellyjac
Copy link
Member

Im not a fan of this.
If this is for kubesec-webhook what was wrong with cloning the repo here, doing a build, and pushing, all in this repo?

@mrcdb
Copy link
Member

mrcdb commented Nov 19, 2023

Im not a fan of this. If this is for kubesec-webhook what was wrong with cloning the repo here, doing a build, and pushing, all in this repo?

I have a PR open for that in the kubesec-webhook repo: controlplaneio/kubesec-webhook#33 . My only (minor) concern about managing webhook release from this repo is with the versioning of the container image. The way we are doing this for kubesec is by using the same version number as in the tag triggering the GHA, which would be obviously different for kubesec-webhook.

@06kellyjac
Copy link
Member

It wasn't meant to be a permanent solution & could have had a hard coded commit/tag in yaml plus manual trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants