Remove browserchannel as a dependency #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only effects the "native" client, not the web client. Hopefully only a temporary measure until I backport some of the changes from TC.
Some have temporarily been commented out, but hopefully re-enable them Soon™
tiagoamaro
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browserchannel (and it's sub-dependencies) have a litany of security issues, although we aren't actually using it in production any more, it's presence is making it difficult to upgrade other libraries.
This removes browserchannel to free up some of the interdependencies and let us update things like connect and express in other projects.
Some tests have been (hopefully temporarily) commented out, I plan to backport some of the client modifications we made elsewhere which may fix some of these tests and let us re-enable them.
SockJS and socket.io are likely next on the hit list, and should be much easier to remove than browserchannel was.