Adding/extending support for several unhandled block types (GitBook Page refs,Hint,Anchor,Emoji node,inline-image,etc) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dove in to just fix page links, ended up finding and touching up a variety of other things I ran into.
Changes
personal
, not just an organization spaceundefined
, now are connected to the actual page metadata and look like[Submit](/docs/requests/submit "Submit a Request")
undefined
, now are rendered as block quote with emoji (see README for example).undefined
undefined
QA
Areas for potential improvement
I was moving fast and didn't have the time to hit every area I might have liked to.
files
lookup dict could be combined with thespaceContent
data that I added to the markdown rendererGitBook
links rendering, in case you want to keep the same structure at the new destination for your markdown but it sits under a different path.