Merge pull request #6 from conveyal/dev

Next release
conveyal · Aug 20, 2021 · 687e9a2 · 687e9a2
2 parents 42317d5 + 00276a0
commit 687e9a2
Show file tree

Hide file tree

Showing 13 changed files with 8,696 additions and 6,915 deletions.
diff --git a/.flowconfig b/.flowconfig
diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
@@ -0,0 +1,37 @@
+name: Node.js CI
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 14
+        uses: actions/setup-node@v2
+        with:
+          node-version: 14.x
+      - name: Install npm packages using cache
+        uses: bahmutov/npm-install@v1
+        with:
+          # the IBI Group TSDX fork has some dependency issues
+          # that cause yarn install to fail on a ci runner. Disabling
+          # concurrency allows installation to complete successfully
+          install-command: yarn --frozen-lockfile --network-concurrency 1
+      - name: Lint Code
+        run: yarn lint
+      - name: Lint Docs
+        run: yarn lint-docs
+      - name: Test Code
+        run: yarn test-node
+      - name: Build Package
+        run: yarn build
+
+      # at this point, the build is successful
+      - name: Semantic Release
+        if: github.event_name == 'push' && github.ref == 'refs/heads/master'
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+        run: yarn semantic-release
diff --git a/.gitignore b/.gitignore
@@ -34,4 +34,11 @@ jspm_packages/
 .yarn-integrity
 
 # built files
-build
+build/*
+dist/*
+
+# OS X
+.DS_Store
+
+# Handled by TSDX
+.eslintrc.js
diff --git a/.npmignore b/.npmignore
@@ -2,7 +2,5 @@
 tmp
 __tests__
 coverage
-flow-typed
-.flowconfig
-.travis.yml
 yarn.lock
+.github
diff --git a/.travis.yml b/.travis.yml
diff --git a/__tests__/__snapshots__/index.js.snap → __tests__/__snapshots__/index.test.ts.snap b/__tests__/__snapshots__/index.js.snap → __tests__/__snapshots__/index.test.ts.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`basic autocomplete g-a-g response 1`] = `
+exports[`geocoder-arcgis-geojson autocomplete should make basic autocomplete query: basic autocomplete g-a-g response 1`] = `
 Object {
   "features": Array [
     Object {
@@ -60,9 +60,43 @@ Object {
 }
 `;
 
-exports[`basic autocomplete request uri 1`] = `"/arcgis/rest/services/World/GeocodeServer/suggest?text=123%20main%20st&outFields=*&maxSuggestions=10&f=json"`;
+exports[`geocoder-arcgis-geojson autocomplete should make basic autocomplete query: basic autocomplete request uri 1`] = `"/arcgis/rest/services/World/GeocodeServer/suggest?text=123%20main%20st&outFields=*&maxSuggestions=10&f=json"`;
 
-exports[`basic bulk g-a-g response 1`] = `
+exports[`geocoder-arcgis-geojson bulk should handle bulk query resulting in no address found: bulk g-a-g response with no address found 1`] = `
+Object {
+  "features": Array [
+    Object {
+      "geometry": Object {
+        "coordinates": Array [
+          0,
+          0,
+        ],
+        "type": "Point",
+      },
+      "properties": Object {
+        "confidence": 0,
+        "country": "",
+        "country_a": "",
+        "county": "",
+        "label": "Address not found",
+        "locality": "",
+        "name": "",
+        "neighbourhood": "",
+        "region": "",
+        "resultId": 0,
+      },
+      "type": "Feature",
+    },
+  ],
+  "query": Object {
+    "addresses": Array [
+      "aefgjil",
+    ],
+  },
+}
+`;
+
+exports[`geocoder-arcgis-geojson bulk should make basic bulk query: basic bulk g-a-g response 1`] = `
 Object {
   "features": Array [
     Object {
@@ -71,7 +105,7 @@ Object {
           -68.28902999999997,
           44.29358000000008,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "confidence": 1,
@@ -85,7 +119,7 @@ Object {
         "region": "Maine",
         "resultId": 0,
       },
-      "type": "feature",
+      "type": "Feature",
     },
   ],
   "query": Object {
@@ -96,7 +130,7 @@ Object {
 }
 `;
 
-exports[`basic reverse g-a-g response 1`] = `
+exports[`geocoder-arcgis-geojson reverse should make basic reverse query: basic reverse g-a-g response 1`] = `
 Object {
   "features": Array [
     Object {
@@ -105,7 +139,7 @@ Object {
           -122.00718855545652,
           37.060855792976916,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "country_a": "USA",
@@ -116,19 +150,19 @@ Object {
         "neighbourhood": "",
         "region": "California",
       },
-      "type": "feature",
+      "type": "Feature",
     },
   ],
   "query": Object {
-    "lat": 37.06146,
-    "lon": -122.006443,
+    "x": -122.006443,
+    "y": 37.06146,
   },
 }
 `;
 
-exports[`basic reverse request uri 1`] = `"/arcgis/rest/services/World/GeocodeServer/reverseGeocode?location=-122.006443%2C37.06146&maxLocations=10&f=json"`;
+exports[`geocoder-arcgis-geojson reverse should make basic reverse query: basic reverse request uri 1`] = `"/arcgis/rest/services/World/GeocodeServer/reverseGeocode?location=-122.006443%2C37.06146&maxLocations=10&f=json"`;
 
-exports[`basic search g-a-g response 1`] = `
+exports[`geocoder-arcgis-geojson search should make basic search query: basic search g-a-g response 1`] = `
 Object {
   "features": Array [
     Object {
@@ -137,7 +171,7 @@ Object {
           -68.28902999999997,
           44.29358000000008,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "confidence": 1,
@@ -151,15 +185,15 @@ Object {
         "region": "Maine",
         "resultId": undefined,
       },
-      "type": "feature",
+      "type": "Feature",
     },
     Object {
       "geometry": Object {
         "coordinates": Array [
           175.91785000000004,
           -37.552359999999965,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "confidence": 0.7440000000000001,
@@ -173,15 +207,15 @@ Object {
         "region": "",
         "resultId": undefined,
       },
-      "type": "feature",
+      "type": "Feature",
     },
     Object {
       "geometry": Object {
         "coordinates": Array [
           -93.16481632584107,
           42.01650127782905,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "confidence": 0.6713,
@@ -195,15 +229,15 @@ Object {
         "region": "Iowa",
         "resultId": undefined,
       },
-      "type": "feature",
+      "type": "Feature",
     },
     Object {
       "geometry": Object {
         "coordinates": Array [
           -93.16319981148884,
           42.016789740145164,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "confidence": 0.6713,
@@ -217,15 +251,15 @@ Object {
         "region": "Iowa",
         "resultId": undefined,
       },
-      "type": "feature",
+      "type": "Feature",
     },
     Object {
       "geometry": Object {
         "coordinates": Array [
           7.554969892325715,
           52.121028096728054,
         ],
-        "type": "point",
+        "type": "Point",
       },
       "properties": Object {
         "confidence": 0.604,
@@ -239,7 +273,7 @@ Object {
         "region": "Nordrhein-Westfalen",
         "resultId": undefined,
       },
-      "type": "feature",
+      "type": "Feature",
     },
   ],
   "query": Object {
@@ -248,38 +282,4 @@ Object {
 }
 `;
 
-exports[`basic search request uri 1`] = `"/arcgis/rest/services/World/GeocodeServer/findAddressCandidates?outFields=*&maxLocations=10&SingleLine=123%20main%20st&f=json"`;
-
-exports[`bulk g-a-g response with no address found 1`] = `
-Object {
-  "features": Array [
-    Object {
-      "geometry": Object {
-        "coordinates": Array [
-          0,
-          0,
-        ],
-        "type": "point",
-      },
-      "properties": Object {
-        "confidence": 0,
-        "country": "",
-        "country_a": "",
-        "county": "",
-        "label": "Address not found",
-        "locality": "",
-        "name": "",
-        "neighbourhood": "",
-        "region": "",
-        "resultId": 0,
-      },
-      "type": "feature",
-    },
-  ],
-  "query": Object {
-    "addresses": Array [
-      "aefgjil",
-    ],
-  },
-}
-`;
+exports[`geocoder-arcgis-geojson search should make basic search query: basic search request uri 1`] = `"/arcgis/rest/services/World/GeocodeServer/findAddressCandidates?outFields=*&maxLocations=10&SingleLine=123%20main%20st&f=json"`;