Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainers version to Node 20 #525

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

weaversam8
Copy link
Contributor

Using the devcontainers approach mentioned in the README did not work on my Apple Silicon Mac. To fix it, I updated the devcontainer image to use a newer node version, and updated the version of emsdk. Both now support the arm64 architecture.

@welcome
Copy link

welcome bot commented Sep 20, 2023

Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request✨ 🙌.We will get back to you as soon as we can.😄

@vercel
Copy link

vercel bot commented Sep 20, 2023

@weaversam8 is attempting to deploy a commit to the Github1s Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there weaversam8 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review it soon!

github1s fosters an open and welcoming environment for all our contributors.🌸

@weaversam8 weaversam8 changed the title Update devcontainers versions Update devcontainers version to Node 20 Sep 21, 2023
@weaversam8
Copy link
Contributor Author

I realized I needed to update one underlying devdependency for this package, eslint-plugin-jsdoc. I did that and tested the application in the latest commit, and it works as expected.

Copy link
Owner

@conwnet conwnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
github1s ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 7:59am

@conwnet conwnet merged commit 7a769bd into conwnet:master Sep 26, 2023
14 checks passed
@welcome
Copy link

welcome bot commented Sep 26, 2023

Congrats on merging your first pull request! 🎉🎉🎉 We here at github1s are proud of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants