-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainers version to Node 20 #525
Conversation
Hello there!👋 Welcome to the project!💖 Thank you and congrats🎉 for opening your first pull request✨ 🙌.We will get back to you as soon as we can.😄 |
@weaversam8 is attempting to deploy a commit to the Github1s Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there weaversam8 👋
Thank you and congrats 🎉 for opening your first PR on this project.✨
We will review it soon!
github1s fosters an open and welcoming environment for all our contributors.🌸
I realized I needed to update one underlying devdependency for this package, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7ee3ed8
to
fdd88a7
Compare
Congrats on merging your first pull request! 🎉🎉🎉 We here at github1s are proud of you! |
Using the devcontainers approach mentioned in the README did not work on my Apple Silicon Mac. To fix it, I updated the devcontainer image to use a newer node version, and updated the version of emsdk. Both now support the
arm64
architecture.