Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: withdraw functionality #32

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feature: withdraw functionality #32

wants to merge 15 commits into from

Conversation

SarahHouben
Copy link

No description provided.

dendavidov
dendavidov reviewed Jun 18, 2020
View reviewed changes
src/types/custom.d.ts Outdated Show resolved Hide resolved
@iourisorokine iourisorokine requested a review from dendavidov June 18, 2020 16:54
a-w-e-s-o-m-e
a-w-e-s-o-m-e requested changes Jun 18, 2020
View reviewed changes
src/commands/withdraw.ts Outdated Show resolved Hide resolved
src/commands/withdraw.ts Outdated Show resolved Hide resolved
@a-w-e-s-o-m-e
Copy link
Contributor

Awesume job! great PR, the withdraw function was much needed.

much claps, much wow!

a-w-e-s-o-m-e
a-w-e-s-o-m-e requested changes Jun 22, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
a-w-e-s-o-m-e
a-w-e-s-o-m-e reviewed Jul 1, 2020
View reviewed changes
src/commands/withdraw.ts
if (+amount < 2) {
await context.sendText(
`Such low amount! Much too low to cover fees! ${utils.generateWow()}`
`Looks like this amount is above your balance (+ 2 doge to cover fees) - you only have ${availableBalance} doge!`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fee is 1 DOGE... but I think is fine anyway :)

@a-w-e-s-o-m-e
Copy link
Contributor

@SarahHouben @iourisorokine really amazing PR 👏 👏 !

I would say this PR is ready to be merged, but we have a major refactor coming from #35 which implements some urgent changes, so probably there will be some conflicts. I'll be able to help you in solving them :)

After #35 is merged, we'll merge this and cooldoge will look cooler than ever! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-w-e-s-o-m-e a-w-e-s-o-m-e a-w-e-s-o-m-e requested changes

@dendavidov dendavidov Awaiting requested review from dendavidov

@iourisorokine iourisorokine Awaiting requested review from iourisorokine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SarahHouben @a-w-e-s-o-m-e @dendavidov @iourisorokine