Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Improve seeders #3518

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Refactor: Improve seeders #3518

merged 9 commits into from
Sep 27, 2024

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Sep 20, 2024

Changes

  • Fix: Typo in install script
  • Refactor: I have removed a ton of commented and empty seeders as these are not needed now (and most likely never will be need) and just make it more complex to manage seeders, now it will be easier and more straight forward (if this is not welcome tell me and I will undo the commits for these changes). I will have to create some more seeders for my big permission PR, so this is a step in the right direction. If we need the seeders in the future, we can just create fresh ones.

-> I also have some more ideas and plans to improve the seeders in the future, but these would include bigger modification and also new features and possibly could introduce new bugs, so I will hold on to those for the next time when I have a more detailed plan (because we are currently in a feature freeze.).

@peaklabs-dev peaklabs-dev changed the title Refactor: Improve seeders [WIP] Refactor: Improve seeders Sep 20, 2024
@peaklabs-dev peaklabs-dev added the 🏔️ Peaklabs A label for PRs from Peaklabs. label Sep 27, 2024
@peaklabs-dev peaklabs-dev marked this pull request as ready for review September 27, 2024 10:21
@andrasbacsai andrasbacsai changed the title [WIP] Refactor: Improve seeders Refactor: Improve seeders Sep 27, 2024
@andrasbacsai
Copy link
Member

Thank you for the PR! Removing unnecessary things are always welcomed.

@andrasbacsai andrasbacsai merged commit 55847d9 into next Sep 27, 2024
4 checks passed
@github-actions github-actions bot removed the 🏔️ Peaklabs A label for PRs from Peaklabs. label Sep 27, 2024
@peaklabs-dev peaklabs-dev deleted the improve-seeders branch September 27, 2024 15:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants