Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unreachable Notifications #4586

Merged

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Dec 15, 2024

Changes

  • Fix: Unreachable notifications were sent even if the server was probably reachable and just had some minor temporary connection problems.
  • fix: duplicated ServerCheckJob in dev
  • Feat: New unreachable notification handling:
    • When a server becomes unreachable (is_reachable set to false), the first time is discarded and is_reachable is set back to true.
    • If the server is unreachable again 1min later (or 5min later for Cloud) set and checked via the ServerCheckJob, it will start 3 fast checks in 5s intervals (locally this will take 15s, remote servers will take about 15s each check so all 3 checks 45s).
    • If these 3 quick status checks also fail, we can be pretty sure that the server is probably offline and then we send out the unreachable notification.

Note

  • I added an event because the first check when I set is_reachable back to true always triggered the second step (because of isDirty), which is not what we want.

Issues

/claim #4407

@peaklabs-dev peaklabs-dev added the 🏔️ Peaklabs A label for PRs from Peaklabs. label Dec 16, 2024
@peaklabs-dev peaklabs-dev marked this pull request as ready for review December 16, 2024 13:28
@andrasbacsai
Copy link
Member

Thank you for the PR!

@andrasbacsai andrasbacsai merged commit efacec4 into coollabsio:next Dec 17, 2024
1 check passed
@github-actions github-actions bot removed the 🏔️ Peaklabs A label for PRs from Peaklabs. label Dec 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants