[16.0][ADD] hr_timesheet_overtime_rate: Add hours_worked field #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
This functionality was completely unlinked from the rest of hr_timesheet_overtime. I would have done this in two commits, but then the files wouldn't move over cleanly, losing history. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
changed the title
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
3 tasks
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
16.0-refactor-overtime-compute
branch
from
df0bc5c to
90d017e
Compare
|
@huguesdk ready for review |
This was referenced Jul 18, 2024
…pi.model method This makes it easier to extend with additional available information on the record. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
16.0-refactor-overtime-compute
branch
from
a111618 to
22179d1
Compare
huguesdk
requested changes
Sep 10, 2024
There was a problem hiding this comment.
since this module doesn’t depend on hr_timesheet_overtime, shouldn’t it be named something like hr_timesheet_worktime_rate? all its ui mentions “overtime rate”, though.
There was a problem hiding this comment.
You're technically right, but this would require more refactoring and migration scripts. I propose we don't do this because there is no real need for this at the moment.
No functional differences; code is a little prettier. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
16.0-refactor-overtime-compute
branch
from
8e9dc38 to
509de5b
Compare
By decreasing the priority, we make sure that hours_worked is as close to unit_amount as possible. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
16.0-refactor-overtime-compute
branch
from
2136f92 to
faf9def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should hopefully fix the problem described in #33 (comment)
I'm not 100% about this PR at time of writing:
I feel like everything related to different rates on certain days is not at all related to the rest of this module. This is a part of that. Maybe it should be factored out?Done.Odoo task (if applicable)
T12629
Checklist before approval