DO NOT MERGE: Custom changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests here are ultimately not very interesting. |
|
In 8b8df74 I upped the prettier version for both Odoo 12 and Odoo 14. I get a super weird bug on Fedora 35 where an older version just wipes the contents of all XML files. I'm not sure how to debug that, and it'll be really annoying for development work on OCA 14.0. |
carmenbianca
force-pushed
the
custom
branch
10 times, most recently
from
b66b368 to
642b9e6
Compare
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
The new tests were copied from the 13.0 template. Signed-off-by: Carmen Bianca Bakker <[email protected]>
black 19.x doesn't respect trailing commas in lists flake8 3.4.x does not run on Python <3.8. The old prettier version doesn't behave correctly on new operating systems (Fedora 35). pylint-odoo 3.5.0 doesn't work on Python <3.10. Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Conflicts:
src/.github/workflows/{% if ci == 'GitHub' %}test.yml{% endif %}.jinja
src/.github/workflows/{% if github_enable_stale_action %}stale.yml{% endif %}
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
[IMP] Include .pkg in .gitignore
…fault in Odoo >= 18.0
prettier 3.x with prettier-xml plugin is affected by prettier/prettier#15696
Ubuntu 20.04 uses Python3.8
[IMP] Set OCA_ENABLE_CHECKLOG_ODOO by default starting with Odoo 18.0
Add version 18
Don't enforce po pretty format that raises if a msgid has the same value as the msgstr. As weblate has those values, it will lead to problems. Moreover, in some languages, some translations can have the same value as the original language.
[FIX] oca-check-po: don't check po-pretty-format
… refactor environment variables for clarity
[FIX] Move enable_checklog_odoo check outside of nested conditional
Silence ruff configuration warnings for 18
The configuration file format has changed, and it does work well with pre-commit. So we keep the previous version for now.
Revert eslint upgrade
…clude new .cjs ones
[IMP] pre-commmit: Run prettier and eslint as local hooks and update versions in v18
…ylint-odoo-to-enable-support-for-v18 [FIX] pre-commit: update pylint odoo to enable valid-odoo-versions key for v18
Update GitHub checkout action from v3 to v4 in workflow
To silence the warning message: The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Bump checkout and setup-python GitHub actions
…lid PRs, if no test are executed. Trouble introduced since OCA#271 on V18 branch
…-test [FIX] Add checklog-odoo configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom changes on top of OCA#117
This PR exists to track + discuss the changes