Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updating): don't validate computed values #1785

Merged

Conversation

sisp
Copy link
Member

@sisp sisp commented Sep 23, 2024

I've fixed the update algorithm to always re-compute computed values in low-level copy calls, which fixes #1779 as side effect.

@sisp sisp requested a review from yajo September 23, 2024 13:53
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (3216628) to head (8825f26).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
+ Coverage   97.63%   97.65%   +0.01%     
==========================================
  Files          49       49              
  Lines        5164     5196      +32     
==========================================
+ Hits         5042     5074      +32     
  Misses        122      122              
Flag Coverage Δ
unittests 97.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisp sisp force-pushed the fix/updating-dont-validate-computed-values branch from 39681b0 to 8825f26 Compare October 21, 2024 14:32
@yajo yajo merged commit b2f584d into copier-org:master Oct 21, 2024
22 checks passed
@sisp sisp deleted the fix/updating-dont-validate-computed-values branch October 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent validator behavior between copier {copy,recopy} and copier update for computed values
2 participants