Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show usernames in send confirmation drawer #3196

Merged
merged 3 commits into from
Mar 7, 2023
Merged

show usernames in send confirmation drawer #3196

merged 3 commits into from
Mar 7, 2023

Conversation

wentokay
Copy link
Collaborator

@wentokay wentokay commented Mar 6, 2023 •
edited
Loading

fixes #2802
fixes #3198

  • support solana transactions
  • support ethereum transactions
  • support when a user sends to one of their own wallets
  • show sender's wallet name?

Note
usernames and wallet names could be indistinguishable if users put an @ symbol in their wallet names (issue #3202)

sending to...

another solana user a different wallet owned by the user
Screenshot 2023-03-06 at 16 38 24 Screenshot 2023-03-06 at 16 38 17
another solana user another ethereum user a different wallet owned by the user
Screenshot 2023-03-06 at 16 26 12 Screenshot 2023-03-06 at 16 27 31 Screenshot 2023-03-06 at 16 26 00

@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
backpack ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 3:47PM (UTC)

@wentokay wentokay mentioned this pull request Mar 7, 2023
Closed
@wentokay wentokay requested a review from trucy March 7, 2023 00:40
@wentokay wentokay marked this pull request as ready for review March 7, 2023 15:54
@wentokay wentokay merged commit a8079c1 into master Mar 7, 2023
@wentokay wentokay deleted the wen/usernames-in-send branch March 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trucy trucy Awaiting requested review from trucy

Assignees
No one assigned
Labels
extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't show @ before wallet name when sending to one of your own wallets Add usernames to review send drawer
1 participant
@wentokay