Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 20 issues #4294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const SendLamportSignMessageButton: FC = () => {

const serializedTransactoin = transaction.serializeMessage();
// const [signature, { blockhash, lastValidBlockHeight }] = await Promise.all([
// wallet.signMessage!(new Uint8Array(serializedTransactoin)),
// wallet.signMessage!(new Uint8Array(serializedTransaction)),
// connection.getLatestBlockhash(),
// ]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const OnboardAccount = ({
]
: []),
...(keyringType === "mnemonic" || keyringType === "ledger"
? // if were importing mnemonic of ledger we need to select the blockchiain
? // if were importing mnemonic of ledger we need to select the blockchain
[
<BlockchainSelector
key="BlockchainSelector"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export function ImportWallets({
const result = result_.wallets[0].walletDescriptors.map(
(descriptor) => ({
...descriptor,
mnemonic, // bring back option for mnemonic === true to differentiat privatkey_derived & mnemnoic
mnemonic, // bring back option for mnemonic === true to differentiate privatkey_derived & mnemnoic
})
) as WalletDescriptor[];
setImportedPublicKeys(
Expand Down Expand Up @@ -278,7 +278,7 @@ export function ImportWallets({
}, [fetchPublicKeys]);

//
// Clear accounts and selected acounts on change of derivation path.
// Clear accounts and selected accounts on change of derivation path.
//
useEffect(
() => {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-extension/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ document.addEventListener("keydown", async function onKeyDown(event) {
});

// Render the UI.
// TOOD(react) createRoot is required: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis
// TODO(react) createRoot is required: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis
const container = document.getElementById("root");
const root = createRoot(container!);
root.render(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function SendCollectibleNavigator({
>
<Stack.Screen
name={Routes.SendCollectibleAddressSelectScreen}
// @ts-ignore: todo: update this hack once we actually embed this navigator in a parent naviagator.
// @ts-ignore: todo: update this hack once we actually embed this navigator in a parent navigator.
component={(props: SendCollectibleAddressSelectScreenProps) => (
<SendCollectibleAddressSelectScreen
{...props}
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/browser/uiActionRequestManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class UiActionRequestManager {
}

public static async cancelAllRequests() {
// Copy the array to aviod mutating it during iteration.
// Copy the array to avoid mutating it during iteration.
const routines = [...UiActionRequestManager._routines];
routines.forEach(({ cancelRoutine }) => {
cancelRoutine();
Expand Down
2 changes: 1 addition & 1 deletion packages/provider-injection/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
ToMobileAppTransportSender,
} from "@coral-xyz/secure-clients";

// This is a bit of a hack, it's speicifically at the top of this file
// This is a bit of a hack, it's specifically at the top of this file
// to ensure it's loaded before other code
if (globalThis.ReactNativeWebView && !globalThis.isHiddenWebView) {
Object.defineProperty(window, "___fromApp", {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export async function migrate_0_2_0_510(

// Migration:
//
// - moves the wallet data object to a user specfic location.
// - moves the wallet data object to a user specific location.
// - clears out the old global wallet data object.
async function migrateWalletData_0_2_0_510(
userInfo: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class ToSecureUITransportSender<
globalThis.chrome?.runtime?.onConnect.addListener((port) => {
logger.debug("Plugin Connected", port.name);

// if we are still connected to a differnt plugin disconnect it
// if we are still connected to a different plugin disconnect it
if (this.port && this.port?.name !== port.name) {
this.disconnectPlugin(this.port);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/secure-background/src/types/transports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {
import type { TransportResponder } from "../transports/TransportResponder";

type SerializeableValues =
| SolanaSignInInput // unfortunatly this is necessary due to this being an interface.
| SolanaSignInInput // unfortunately this is necessary due to this being an interface.
| undefined
| null
| boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class EthereumProvider {
): Promise<any> {
const { walletPublicKey, ethereumClient } = ctx;

// transfrom transaction from ethers5 to ethers6
// transform transaction from ethers5 to ethers6
const transaction = Transaction.from(
ethers5.utils.serializeTransaction(tx as UnsignedTransaction)
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class BackpackSolanaConnection extends Connection {
//
// We sort the data so that we can have a consistent key when teh data
// doesn't change. We remove the mints and metadata from the key because
// it's not neceessary at all when calculating whether something has
// it's not necessary at all when calculating whether something has
// changed.
//
return JSON.stringify({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ function splitOutNfts(
}
}
//
// Token standard not available so use decimals to determin if it's an NFT.
// Token standard not available so use decimals to determine if it's an NFT.
//
else {
const mint = mintsMap.get(token.mint.toString());
Expand Down
2 changes: 1 addition & 1 deletion packages/secure-clients/src/TensorClient/TensorClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ export class TensorClient {
return true;
}

// group attribues by type (same type -> OR, different type -> AND)
// group attributes by type (same type -> OR, different type -> AND)
const groupedAttributes: {
[type: string]: string[];
} = {};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function executeLedgerFunction<R, T extends Transport>(

const isError = isLedgerError(e?.message);
if (isError("HID_PERMISSIONS_NOT_AVAILABLE")) {
// It's not uncommon to get one / two permissions error before succesfull connect.
// It's not uncommon to get one / two permissions error before successful connect.
// so we just count the errors and act on them after the gesture timer ran out.
HID_PERMISSIONS_NOT_AVAILABLE_count++;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/secure-ui/src/_atoms/requestAtoms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const currentRequestAtom = selector<TransportResponder<
const nextPending = queue.find((event) => !event.responded);
// if we dont have any pending, return the last already responded event
// so the screen does not go blank while animating out.
// <Presentation> automatically disables intracting with responded events.
// <Presentation> automatically disables interacting with responded events.
return nextPending ?? queue[0] ?? null;
},
// this prevents recoil from freezing the object in dev mode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const solanaMutatedTransactionAtom = selectorFamily<
);
return mutatedTx;
} catch {
// if somethign fails return original transaction
// if something fails return original transaction
return request.tx;
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const solanaTxDowngradableAccountsAtom = selectorFamily<
return true;
} else if (!simulationAccount) {
// TODO: This just means the simulation RPC response doesn't have the account
// could be an indetermine state of the account.
// could be an indeterminate state of the account.
return false;
}
return (
Expand Down
2 changes: 1 addition & 1 deletion packages/tamagui-core/src/components/ProxyImage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
type StyleProp,
} from "react-native";

// React Native apps need to specifcy a width and height for remote images
// React Native apps need to specify a width and height for remote images
export const ProxyImage = ({
onError,
src,
Expand Down