Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use centralized config #39

Merged
merged 1 commit into from
Sep 30, 2024
Merged

chore: use centralized config #39

merged 1 commit into from
Sep 30, 2024

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Sep 30, 2024

No description provided.

Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi requested a review from a team September 30, 2024 14:10
Copy link
Member

@M4tteoP M4tteoP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for centralized config. What I'm missing is what file is pointing to.
I'm reading from https://docs.renovatebot.com/config-overview/:

Renovate will also check for a renovate.json file if it cannot find a default.json file in a preset, however this option is deprecated and not recommended.

In corazawaf/renovate-config we have both files, should we remove the renovate.json and merge configs to default.json, or are they somehow coexisting?

@fzipi
Copy link
Member Author

fzipi commented Sep 30, 2024

We should move everything to defauls, yes. Let me do that in the other repo.

@fzipi
Copy link
Member Author

fzipi commented Sep 30, 2024

Done, merged.

@fzipi fzipi merged commit 99eb4a1 into main Sep 30, 2024
1 check passed
@fzipi fzipi deleted the update-renovate-config branch September 30, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants