Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files #16

Merged
merged 4 commits into from
Jan 16, 2024
Merged

add files #16

merged 4 commits into from
Jan 16, 2024

Conversation

nihinihikun
Copy link
Contributor

以下確認して消してからプルリク出してください

概要

  • Cstylecastiong関係の警告に対する対処とそれをGitHubActionsにみてもらうためのプルリク

@nihinihikun nihinihikun self-assigned this Jan 13, 2024
Nose/Nose.ino Outdated Show resolved Hide resolved
Copy link
Member

@771-8bit 771-8bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとだけ気になるので修正&コメントお願い

Nose/Nose.ino Outdated Show resolved Hide resolved
Nose/Nose.ino Outdated Show resolved Hide resolved
Nose/Nose.ino Outdated
}
if (CCP.str_match("KILL", 4)) {
sleep_sensors = true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KILLしたあと復帰する手段なくていい?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleep_sensorsをCCP_EMST_mesureとCCP_nose_adcの両方で操作してるけどどういう操作?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCP_EMST_mesureは機体圧力側も同時にkillしたい時用

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

理解
ok

@nihinihikun
Copy link
Contributor Author

@771-8bit これマージしてほしい.マージしたらノーズ基板のパターンミスの修正したい

@771-8bit 771-8bit merged commit 9aba2b4 into main Jan 16, 2024
5 checks passed
@nihinihikun nihinihikun deleted the nose_software_repair_cstylecastiong2 branch January 16, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants