Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nose develop #7

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Nose develop #7

merged 9 commits into from
Dec 18, 2023

Conversation

nihinihikun
Copy link
Contributor

@nihinihikun nihinihikun commented Dec 18, 2023 •
edited
Loading

  • 各項目は今回のプロジェクトでのGitHubの使い方を参考に書く
  • 画面右のreviewrを @771_8bit に，assigneeを自分に設定する
  • 作業中のメモはプルリク上に残す<-　のこしたいメモはmemo.ipynbで管理
  • レビューができる状態になったらレビュー時を参考にコメントを書く

概要

  • ハードウェア，部品選定関係

背景

  • 選定した経緯とかはREADMEとかmemo.ipynbにかいてる

変更範囲

  • ハードウェア開発はこのプルリクで，ソフトウェア開発は別のプルリクで

@nihinihikun nihinihikun self-assigned this Dec 18, 2023
@nihinihikun
Copy link
Contributor Author

@771-8bit ハードウェア関係のチェックお願いします．

771-8bit
771-8bit requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@771-8bit 771-8bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihinihikun 画像以外はOK

Nose/README.md

### PCB

<img src="images/PCB1.png" width="300"><img src="images/PCB2.png" width="400">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この画像最新じゃないので更新してください

771-8bit
771-8bit approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@771-8bit 771-8bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihinihikun おっけーですあざす

@nihinihikun nihinihikun merged commit 4e65bcc into main Dec 18, 2023
4 checks passed
@nihinihikun nihinihikun deleted the nose_develop branch December 18, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@771-8bit 771-8bit 771-8bit approved these changes

Assignees

@nihinihikun nihinihikun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nihinihikun @771-8bit