Skip to content

Commit

Permalink
DynamicTablesPkg: Fix ETE _UID Creation
Browse files Browse the repository at this point in the history
Bugzilla: 4600 (https://bugzilla.tianocore.org/show_bug.cgi?id=4600)

Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName

Signed-off-by: Ashish Singhal <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
  • Loading branch information
ashishsingha authored and mergify[bot] committed Nov 21, 2023
1 parent 3db76e6 commit 23dbb8a
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ CreateAmlCpcNode (
@param [in] Generator The SSDT Cpu Topology generator.
@param [in] ParentNode Parent node to attach the Cpu node to.
@param [in] GicCInfo CM_ARM_GICC_INFO object used to create the node.
@param [in] CpuName Value used to generate the node name.
@param [out] EtNodePtr If not NULL, return the created Cpu node.
Expand All @@ -372,6 +373,7 @@ EFIAPI
CreateAmlEtd (
IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator,
IN AML_NODE_HANDLE ParentNode,
IN CM_ARM_GICC_INFO *GicCInfo,
IN UINT32 CpuName,
OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL
)
Expand All @@ -397,7 +399,7 @@ CreateAmlEtd (

Status = AmlCodeGenNameInteger (
"_UID",
CpuName,
GicCInfo->AcpiProcessorUid,
EtNode,
NULL
);
Expand Down Expand Up @@ -474,6 +476,7 @@ CreateAmlEtNode (
Status = CreateAmlEtd (
Generator,
Node,
GicCInfo,
CpuName,
NULL
);
Expand Down

0 comments on commit 23dbb8a

Please sign in to comment.