Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue
The function UhciConvertPollRate has a check ASSERT (Interval != 0); but this comes into play only in DEBUG mode. In Release mode, there is no handling if the Interval parameter value is ZERO. To avoid shifting by a negative amount later in the code flow in this undesirable case, it is better to handle it as well by treating it same as if 1 is sent. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4211 Cc: Hao A Wu <[email protected]> Cc: Ray Ni <[email protected]> Co-authored-by: Veeresh Sangolli <[email protected]> Signed-off-by: Ranbir Singh <[email protected]> Signed-off-by: Ranbir Singh <[email protected]> Reviewed-by: Hao A Wu <[email protected]>
- Loading branch information