Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coredns/caddy to fix tests #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

pvsune
Copy link

@pvsune pvsune commented Nov 5, 2021

The tests fail:

$ go test ./...
# github.com/coredns/records [github.com/coredns/records.test]
./records_test.go:24:25: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to recordsParse
./records_test.go:83:25: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to recordsParse
./records_test.go:136:25: cannot use c (type *"github.com/caddyserver/caddy".Controller) as type *"github.com/coredns/caddy".Controller in argument to recordsParse
FAIL    github.com/coredns/records [build failed]
FAIL

Looks like there is inconsistency in using caddy in recordsParse(), use the stripped down coredns/caddy instead.

Signed-off-by: Philamer Sune <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant