Add option changing TAB-key behaviour: Focus on the next tabindex, instead of selecting the top-suggestion #181
Conversation
Darnokk
commented
Feb 20, 2018
Darnokk
commented
- The default behaviour of the TAB-key is to select the top suggestion
- We introduced a new option called 'tabAutocomplete' which is NOT mandatory and defaults to true.
- If the option 'tabAutocomplete' is true, the TAB-key will select the top suggestion as usual
- If the option 'tabAutocomplete' is NOT set, the TAB-key will select the top suggestion as usual
- Only if you set the option 'tabAutocomplete' to false pressing the TAB key will change the focus on the html-element with the next tabindex.
- Added option 'tabAutocomplete' to doc
- Added two methods for tabAutocomplete = true resp. false to the unit-test typeahead_spec.js
|
Is there a set date when this will be merged into master? |
|
There's no set date. We'll need some reviews and consensus from other contributors before we merge. Any @corejavascript/collaborators available to review this? |
| spyOn(this.view, 'autocomplete'); | ||
| this.menu.getTopSelectable.andReturn($el); | ||
| this.input.trigger(eventName, payload); | ||
| expect(this.view.autocomplete).toHaveBeenCalledWith($el); |
There was a problem hiding this comment.
This test would be more durable if we could read the resulting HTML and find that the text is there, as I'm doing with tests using enzyme... just because the view was called with the $el does not mean it actually autocompleted right?
Particularly with a loosely-maintained library like this, it's important to have reliable tests - I recommend writing an integration test https://github.com/corejavascript/typeahead.js/tree/master/test/integration
I think @jesperronn tried to revive integration tests but ran into a travis issue
|
Apparently my message didn't get posted - I got the @corejavascript/collaborators message - this library is used at work but it's legacy - I'm focused on react these days. Is there anyone else out there? Might be time to open this up to more collaborators? I think @lenovouser is the owner? (https://github.com/orgs/corejavascript/teams/collaborators/members confirms maintainer role) Cross-posted to https://github.com/orgs/corejavascript/teams/collaborators/discussions/1 |
|
This is still in use at my previous employer, but is also legacy. I'm focused on React now too (thought about recreating this in React, but haven't had the time). I own the NPM package and can still handle build/release tasks, just no time to code review PRs. I'd be happy to have bring in more collaborators. |
|
Thanks for this PR - works great. |
|
We would definitely use this feature. Our app is heavy on data entry, and has a bunch of fields on a single form, a few of which we use typeahead. Our users often want to type something into a field that's a close match, but they want to only keep the data they've typed in. The ability to tab to the next field without selecting the first match would be great! |
|
HI @Darnokk or anyone else still interested in this PR.. I was looking at merging this tonight, but it looks like it has a couple of merge conflicts. Could anyone still interested in this take the time to resolve those so this can be merged cleanly? |
