Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screenshots to README.md #226

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Add Screenshots to README.md #226

merged 1 commit into from
Jan 24, 2024

Conversation

inson1
Copy link
Contributor

@inson1 inson1 commented Jan 24, 2024

Plus I reduced size of the links

@corenting
Copy link
Owner

Thanks for the PR! It just seems the images are broken on Github web interface due to using relative paths instead of an URL like https://github.com/corenting/InflationCalculator/blob/master/fastlane/metadata/android/en-US/images/icon.png.

@inson1
Copy link
Contributor Author

inson1 commented Jan 24, 2024

@corenting they work https://github.com/inson1/InflationCalculator/blob/patch-2/README.md or Im blind
somehow only master readme is showing even in different branch

@corenting
Copy link
Owner

Ah true it only seems broken in the rich diff view of the change, I will merge then

@corenting corenting merged commit d26a643 into corenting:master Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants