Manifests: move zram to system-configuration #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtrystram
added a commit
to jbtrystram/openshift-os
that referenced
this pull request
Apr 3, 2024
FCOS had shipped ZRAM-generator for a while but it was not shared with RHCOS. Moved the package to a different sub-manifest that would regroup kubernetes-specific things. The swap on ZRAM would still need to be actually enabled through a config file [1] but that should be done by the MCO. [1] https://github.com/systemd/zram-generator/blob/main/man/zram-generator.conf.md ref: coreos/fedora-coreos-config#2937 ref: https://issues.redhat.com/browse/COS-2507
|
If we need it in both RHCOS and FCOS then maybe just move it into In the commit message you can mention why (i.e. new kube support for swap). |
|
It's also useful for non-k8s deployments so I'd would also vote for not adding a k8s specific manifest. |
Kubernetes 1.28 now supports swap on zram as beta Moving the zram-generator package to a manifest shared with rhcos. See coreos/fedora-coreos-docs#530
jbtrystram
force-pushed
the
manifests/zram
branch
from
2d1955f to
a9f8f2a
Compare
travier
approved these changes
Apr 8, 2024
travier
changed the title
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 10, 2024
In coreos#2937 we moved zram-generator to the system-configuration.yaml manifest so it's shared with RHCOS. However in the centOS stream 9 zram-generator-0.3.2 [1] ships a default config file, resulting in a swap device being created by default. This ends up breaking kubelet, until kubernetes 1.30 is released [1] https://gitlab.com/redhat/centos-stream/rpms/rust-zram-generator/-/blob/c9s/zram-generator.conf?ref_type=heads
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 10, 2024
In coreos#2937 we moved zram-generator to the system-configuration.yaml manifest so it's shared with RHCOS. However in the centOS stream 9 zram-generator-0.3.2 [1] ships a default config file, resulting in a swap device being created by default. This ends up breaking kubelet, until kubernetes 1.30 is released [1] https://gitlab.com/redhat/centos-stream/rpms/rust-zram-generator/-/blob/c9s/zram-generator.conf?ref_type=heads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 1.28 now supports swap on zram as beta, so we need to ship this package in RHCOS.
Moving zram to a separate manifest that could be optionnaly enabled for k8s use ?
See coreos/fedora-coreos-docs#530