Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc-policy.yaml: Add images and builds pruning #1038

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

gursewak1997
Copy link
Member

Update the gc-policy.yaml to prune the images and the whole builds itself. There's also a field for images-kept which we won't pruning when pruning the artifacts in meta.json's images key for each build.

gc-policy.yaml Outdated Show resolved Hide resolved
@gursewak1997
Copy link
Member Author

I am not sure about the timings for pruning the images/builds and can discuss more on that but this is the format we will have.

@gursewak1997 gursewak1997 removed the hold Waiting for something label Sep 25, 2024
@gursewak1997
Copy link
Member Author

@jlebon @dustymabe need your takes on this.

  • Can we extend the GC to pruning the whole builds, since the code for it is merged. If so, what stream can we test it on and what would the time duration (How old builds do we prune) be?
  • Any changes needed to images duration?

@dustymabe
Copy link
Member

@jlebon @dustymabe need your takes on this.

  • Can we extend the GC to pruning the whole builds, since the code for it is merged. If so, what stream can we test it on and what would the time duration (How old builds do we prune) be?

honestly I wouldn't test on anything but bodhi-updates initially (for any of them). While testing I would start with older times and then progressively get to the time we want (i.e. each time you can iterate on your code if you find problems). ultimately we don't care about bodhi-updates at all anymore so it's a good place to start.

  • Any changes needed to images duration?

I'd say matching the cloud-pruning for now is good and we can look at shortening it later.

@dustymabe
Copy link
Member

IOW I would limit any changes in this PR to bodhi updates (and also consult the builds in that stream to make sure the times that we set here will actually exercise the code).

@gursewak1997 gursewak1997 force-pushed the update-gc-policy-new branch 2 times, most recently from 2e48687 to 32f8cac Compare September 25, 2024 17:04
config.yaml Outdated Show resolved Hide resolved
@gursewak1997 gursewak1997 force-pushed the update-gc-policy-new branch 3 times, most recently from bd59451 to c1bf770 Compare September 26, 2024 17:35
gc-policy.yaml Outdated
Comment on lines 7 to 9
images: 2y
images-keep: [qemu, live-iso]
build: 2y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we go with a different value of times here. i.e. build could be 2y and images could be 18 months? basically you want to see some builds where images was exercised but builds wasn't, right?

Update the gc-policy.yaml to prune the images and
the whole builds itself. There's also a field for
images-kept which we won't pruning when pruning the
artifacts in meta.json's images key for each build.
Also, enable bracnhed and bodhi-updates stream to test
the pruning on it.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gursewak1997 gursewak1997 merged commit 8b4e0de into coreos:main Sep 27, 2024
2 checks passed
@gursewak1997 gursewak1997 deleted the update-gc-policy-new branch September 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants