-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc-policy.yaml: Add images and builds pruning #1038
Conversation
86463b5
to
3c113d1
Compare
I am not sure about the timings for pruning the images/builds and can discuss more on that but this is the format we will have. |
@jlebon @dustymabe need your takes on this.
|
honestly I wouldn't test on anything but bodhi-updates initially (for any of them). While testing I would start with older times and then progressively get to the time we want (i.e. each time you can iterate on your code if you find problems). ultimately we don't care about bodhi-updates at all anymore so it's a good place to start.
I'd say matching the cloud-pruning for now is good and we can look at shortening it later. |
IOW I would limit any changes in this PR to bodhi updates (and also consult the builds in that stream to make sure the times that we set here will actually exercise the code). |
2e48687
to
32f8cac
Compare
bd59451
to
c1bf770
Compare
gc-policy.yaml
Outdated
images: 2y | ||
images-keep: [qemu, live-iso] | ||
build: 2y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we go with a different value of times here. i.e. build could be 2y and images could be 18 months? basically you want to see some builds where images was exercised but builds wasn't, right?
Update the gc-policy.yaml to prune the images and the whole builds itself. There's also a field for images-kept which we won't pruning when pruning the artifacts in meta.json's images key for each build. Also, enable bracnhed and bodhi-updates stream to test the pruning on it.
c1bf770
to
fc06810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the
gc-policy.yaml
to prune the images and the whole builds itself. There's also a field forimages-kept
which we won't pruning when pruning the artifacts in meta.json'simages
key for each build.