providers: support for Proxmox VE (continuation) #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
approved these changes
Jul 22, 2024
|
Also, minor/optional: let's squash it all to one commit (and add yourself as co-author) ? |
Co-authored-by: bri <[email protected]>
|
I tested this PR and it seems to work fine in various situations. I patched the release notes and added Promox VE to supported platforms. I also squashed the PR to a single commit. |
|
@jlebon would you be so kind as to have a look ? |
|
Awesome! 🚀 |
|
Exciting ❤️ |
2 tasks
|
Can any of you elaborate on how to put this to use? I am new to FCOS & ignition and may simply not know where I should be looking. Thanks! |
15 tasks
|
@genebean If you're interested in using this in FCOS, the larger effort is tracked in coreos/fedora-coreos-tracker#736 and coreos/fedora-coreos-tracker#1652. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR is a continuation of #1790. The original PR is doing good, but we cannot push to it and we would like things to go faster so we decided to make another one to finish it.
This PR includes the commit from @b-, and a fix for #1790 (comment). I also added release note.
I think this is good to go. Feel free to tell me otherwise.