Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restructure; update naming pattern and weight; fix inner-link #137

Merged
merged 11 commits into from
Jan 14, 2025

Conversation

dextermallo
Copy link
Contributor

@dextermallo dextermallo commented Aug 5, 2024

Proposed changes

Implement #133

Further comments

(Some headers of page may be incorrect or be duplicated - I don't want to change them at the moment, just want to show the effects of re-order)

@fzipi fzipi requested a review from a team October 11, 2024 01:21
@fzipi
Copy link
Member

fzipi commented Oct 16, 2024

Hi @dextermallo ! Can you rebase your changes?

@dextermallo dextermallo force-pushed the feat/restructure-hierarchy branch from 419494c to 0f7a705 Compare October 17, 2024 02:28
@dextermallo
Copy link
Contributor Author

dextermallo commented Oct 17, 2024

Hi @dextermallo ! Can you rebase your changes?

Done in 0f7a705. Also fix an image-link error :)

content/4-about-plugins/4-1-what-is-plugin.md Outdated Show resolved Hide resolved
content/5-advanced-usages/_index.md Outdated Show resolved Hide resolved
content/7-known-issues/_index.md Outdated Show resolved Hide resolved
@dextermallo
Copy link
Contributor Author

dextermallo commented Nov 13, 2024

Hmm not sure what bumped into my PR; every time I rebase, the PR reverts some of my previous changes.
Perhaps I should wait until folks make a decision to move forward and then make changes one time. Otherwise I have to keep updating it... :(

(The conflicts I saw in the PR should not be existed since the files are renamed and moved)

@fzipi
Copy link
Member

fzipi commented Dec 8, 2024

@dextermallo I've pushed over your branch, hopefully, this works now. This time we are planning to move on with your proposed changes and more people will be around so we can merge.

@fzipi fzipi requested a review from theseion January 2, 2025 11:35
@fzipi
Copy link
Member

fzipi commented Jan 2, 2025

Oh, my I think I broke it 🤦 Fixed.

Copy link

@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure with my requested changes. Just asking questions? ;-)

content/2-how-crs-works/2-3-false-positives-and-tuning.md Outdated Show resolved Hide resolved
content/6-development/6-1-contribution-guidelines.md Outdated Show resolved Hide resolved
@theseion theseion force-pushed the feat/restructure-hierarchy branch from c05c127 to e03d26d Compare January 5, 2025 09:14
@theseion
Copy link
Contributor

theseion commented Jan 5, 2025

Resolved conflicts by rebasing.

@theseion
Copy link
Contributor

theseion commented Jan 5, 2025

bz.apache.org is currently offline, which is why the link check fails.

@theseion
Copy link
Contributor

@dextermallo I hope I didn't mess up the rebase. We should try and get this PR merged ASAP. Could you make the last couple of changes? I will try an push this PR along as fast as possible.

@theseion
Copy link
Contributor

Thanks @dextermallo. I talked to @fzipi and we want to merge this PR now. We think it will be easier to work then and we can continue with smaller PRs. Does that work for you?

@dextermallo
Copy link
Contributor Author

Thanks @dextermallo. I talked to @fzipi and we want to merge this PR now. We think it will be easier to work then and we can continue with smaller PRs. Does that work for you?

Sure definitely :)

@theseion theseion merged commit a4f16ad into coreruleset:main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants