-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure; update naming pattern and weight; fix inner-link #137
feat: restructure; update naming pattern and weight; fix inner-link #137
Conversation
Hi @dextermallo ! Can you rebase your changes? |
419494c
to
0f7a705
Compare
Done in 0f7a705. Also fix an image-link error :) |
Hmm not sure what bumped into my PR; every time I rebase, the PR reverts some of my previous changes. (The conflicts I saw in the PR should not be existed since the files are renamed and moved) |
53a0433
to
27641cc
Compare
@dextermallo I've pushed over your branch, hopefully, this works now. This time we are planning to move on with your proposed changes and more people will be around so we can merge. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure with my requested changes. Just asking questions? ;-)
Signed-off-by: Felipe Zipitria <[email protected]>
c05c127
to
e03d26d
Compare
Resolved conflicts by rebasing. |
|
@dextermallo I hope I didn't mess up the rebase. We should try and get this PR merged ASAP. Could you make the last couple of changes? I will try an push this PR along as fast as possible. |
Thanks @dextermallo. I talked to @fzipi and we want to merge this PR now. We think it will be easier to work then and we can continue with smaller PRs. Does that work for you? |
Sure definitely :) |
Proposed changes
Implement #133
Further comments