Merge pull request #60 from coreweave/dmarx.rename_buildcache

fix(build): move buildcache for clarity
coreweave · Mar 14, 2024 · a5a99e8 · a5a99e8
2 parents 999655b + b1b3096
commit a5a99e8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -77,8 +77,8 @@ jobs:
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
-          cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ inputs.image-name }}:buildcache
-          cache-to: type=registry,ref=${{ env.REGISTRY }}/${{ inputs.image-name }}:buildcache,mode=max
+          cache-from: type=registry,ref=${{ env.REGISTRY }}/buildcache:${{ inputs.image-name }}
+          cache-to: type=registry,ref=${{ env.REGISTRY }}/buildcache:${{ inputs.image-name }},mode=max
       - uses: 8BitJonny/[email protected]
         id: PR
         with:

diff --git a/.github/workflows/torch-extras.yml b/.github/workflows/torch-extras.yml
@@ -141,14 +141,17 @@ jobs:
     name: Build torch-extras via Workflow Call
     if: inputs.skip-bases-check
     strategy:
+      # if you need to build for multiple versions of flash-attn
+      # fix tag-suffix below to reflect your versions in the tag
       matrix:
         flash-attn: [ 2.4.2 ]
     uses: ./.github/workflows/build.yml
     secrets: inherit
     with:
       image-name: ${{ inputs.image-name || 'torch-extras' }}
       folder: torch-extras
-      tag-suffix: ${{ inputs.tag }}-flash_attn${{ matrix.flash-attn }}
+      #tag-suffix: ${{ inputs.tag }}-flash_attn${{ matrix.flash-attn }}
+      tag-suffix: ${{ inputs.tag }}
       build-args: |
         BASE_IMAGE=${{ inputs.base-image }}
         FLASH_ATTN_VERSION=${{ matrix.flash-attn }}
@@ -159,14 +162,17 @@ jobs:
     if: needs.get-required-bases.outputs.bases-list && needs.get-required-bases.outputs.bases-list != '[]'
     strategy:
       matrix:
+        # if you need to build for multiple versions of flash-attn
+        # fix tag-suffix below to reflect your versions in the tag
         flash-attn: [ 2.4.2 ]
         bases: ${{ fromJSON(needs.get-required-bases.outputs.bases-list) }}
     uses: ./.github/workflows/build.yml
     secrets: inherit
     with:
       image-name: ${{ inputs.image-name || 'torch-extras' }}
       folder: torch-extras
-      tag-suffix: ${{ matrix.bases.tag }}-flash_attn${{ matrix.flash-attn }}
+      #tag-suffix: ${{ matrix.bases.tag }}-flash_attn${{ matrix.flash-attn }}
+      tag-suffix: ${{ matrix.bases.tag }}
       build-args: |
         BASE_IMAGE=${{ matrix.bases.image }}
         FLASH_ATTN_VERSION=${{ matrix.flash-attn }}
diff --git a/.github/workflows/torch-nightly.yml b/.github/workflows/torch-nightly.yml
@@ -82,7 +82,7 @@ jobs:
             >> "$GITHUB_OUTPUT";
       - name: Get date
         id: get-date
-        run: echo "date=$(date -u '+%Y.%m.%d.%H')" >> "$GITHUB_OUTPUT";
+        run: echo "date=$(date -u '+%y%m%d%H')" >> "$GITHUB_OUTPUT";
 
   get-base-config:
     name: Get torch:base Config