RGB24 support #15
Open
RGB24 support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albagarrey
approved these changes
Mar 12, 2023
|
This looks like a working change, and solves a pretty relevant problem. Would it be possible to merge it? @sedghi @jody-zeitler |
|
@pcanas Are you using this repo or the new @cornerstonejs/nifti-volume-loader? https://github.com/cornerstonejs/cornerstone3D/tree/main/packages/nifti-volume-loader |
|
@sedghi I was using this one because I thought it was the most updated one. Could you redirect me to an example of the new |
|
@sedghi what changes we would need to make to load an RGB nifti? The code in the example you sent does not seem to work with RGB files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secondary captures are converted to TYPE_RGB24 nifti files, which are currently not supported by cornerstone-nifti. This fork converts to RGB24 data structure to 32-bit data, which can be consumed by cornerstone.js. (could remedy #14 )