Adds Docker support (cross-platform) #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot now runs inside a small(ish) Alpine linux image, with support for Lavalink as the music player. All features have not been tested, and the audio quality/experience may require further testing/tweaking. Support for Windows containers is also planned, but no ETA yet.
Added optional settings dict values for configuring Lavalink
Mounting Settings.json is the only confirmed not working thing right now, everything else seems to work
Added optional settings_dict overrides for both Settings.json and Settings-Backup. This allows the important/persisted data to be separate, but also allows the Docker integration to work better with how the bot stores files etc.
Docker will now default to storing bot data under /data (inside the container), which can easily be mounted in any environment.
- CI will now build both pushes (commits) and pull requests - CI will only deploy images for pushes (commits) - CI will attempt to use the current branch name for the tag, falling back to the commit hash
Allow absolute paths
Updates and fixes left and right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/)Music.pyto optionally read Lavalink settings from the config fileSettings.pyto optionally read customSettings.jsonandSettings-Backuppaths from the config fileNote that this is currently only compatible with the
rewritebranch, but support for databases (Redis, MongoDB etc.) should be trivial to add to the appropriate branch later.