Explicitly specify the static build of AWS-LC for linking #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhosv
force-pushed
the
static-build
branch
2 times, most recently
from
4499856 to
7869ba2
Compare
geedo0
previously approved these changes
Apr 4, 2024
WillChilds-Klein
previously approved these changes
Apr 4, 2024
WillChilds-Klein
force-pushed
the
static-build
branch
from
7869ba2 to
7fbcbfd
Compare
WillChilds-Klein
approved these changes
Apr 4, 2024
geedo0
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In case a customer does not use
build.gradleto build ACCP and have a separate flow for building AWS-LC, we introduce a property that can be pass to CMake that identifies the static build of AWS-LC. When shared objects for AWS-LC are also built,OPENSSL_CRYPTO_LIBRARYdefaults to the shared object. In such cases, one can setOPENSSL_CRYPTO_LIBRARY_STATICso that the static build would be used for linking.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.