Add more duration info to SG request stats log #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est log Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
|
Looks like the issue comes from the latest objstore library. thanos-io/thanos#6742 |
Signed-off-by: Ben Ye <[email protected]>
|
Nice! LGTM |
alanprot
approved these changes
Sep 21, 2023
yeya24
deleted the
add-more-duration-info-store-gateway-series-request-stats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add
get_all_duration,merge_all_durationandresponse_time(total latency) to the querier SG request logs.Upstream pr in thanos: thanos-io/thanos#6730.
Also updated Thanos version and add brings new metrics to Cortex store gateway.
thanos-io/thanos#6726
thanos-io/thanos#6730
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]