Add max tenant config to tenant federation #6493
Open
+140
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-max-tenant-config-to-tenant-federation
branch
from
fb55863 to
296381c
Compare
CharlieTLe
approved these changes
Jan 9, 2025
|
DId you consider just adding the limit for the frontend code? Somewhere around here cortex/pkg/frontend/transport/handler.go Line 184 in d5e9b5f Just curious why a new middleware on api. It seems a bit too generic for a limit on query |
|
@danielblando |
SungJin1212
force-pushed
the
Add-max-tenant-config-to-tenant-federation
branch
5 times, most recently
from
6e4eaa8 to
fa7fd17
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-max-tenant-config-to-tenant-federation
branch
from
fa7fd17 to
beaf3f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag
-tenant-federation.max-tenantto limit the number of tenants to query at once.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]