Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crashing error #1370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paplco
Copy link

@paplco paplco commented Feb 17, 2023

UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch().

This error will cause nodejs to crash when the connection times out. Firewalls will cause timeout.

Error could be gracefully handled.

UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch().

This error will cause nodejs to crash when the connection times out. Firewalls will cause timeout.

Error should be gracefully handled.
@webmaster128
Copy link
Member

webmaster128 commented Mar 1, 2023

Thank you for bringing this up. I think it is better to handle promise resolve and reject of client.connected in the place where this is called. Are you using SocketWrapper directly? Or through some higher level client in CosmJS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants