Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make account parser implementation extendable #1530

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: make account parser implementation extendable #1530

wants to merge 4 commits into from

Commits on Dec 22, 2023

  1. feat: make accountParser implementation extendable 

    - adds AccountParserManager class where consumers can register different accountParsers
- adds createDefaultAccountParser() which instantiates AccountParserManager with common cosmos-sdk account types
- preserves existing accountFromAny interface for backwards compatability
    @0xpatrickdev
    0xpatrickdev committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    ffb1fa1 View commit details
    Browse the repository at this point in the history

  2. feat: add tests for createAccountParserRegistry and AccountParserManager 

    - refactor createDefaultAccountParser (instance) to createAccountParserRegistry (map of accountParsers) for easier testing
    @0xpatrickdev
    0xpatrickdev committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    4cbb028 View commit details
    Browse the repository at this point in the history

  3. feat: export createAccountParserRegistry function, AccountParserManag… 

    …er class, and AccountParserRegistry type
    @0xpatrickdev
    0xpatrickdev committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    9ba311a View commit details
    Browse the repository at this point in the history

  4. docs: add jsdoc descriptions for exported account functions

    @0xpatrickdev
    0xpatrickdev committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    53afd70 View commit details
    Browse the repository at this point in the history