fix for sdk >= v50 #1563
Closed
fix for sdk >= v50 #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pynixwang
commented
Feb 28, 2024
pynixwang
commented
- remove parsedLogs
- fix findAttribute
- fill logs with []
+ remove parsedLogs + fix findAttribute + fill logs with []
Closed
| return { | ||
| contractAddress: contractAddressAttr.value, | ||
| logs: parsedLogs, | ||
| logs: [], |
There was a problem hiding this comment.
Nice, let's deperacte this field
| const firstLogs = logs.find(() => true); | ||
| const out = firstLogs?.events | ||
| export function findAttribute(events: readonly Event[], eventType: string, attrKey: string): Attribute { | ||
| const out = events |
There was a problem hiding this comment.
Let's keep this function unchanged since it is public. Instead we can make a new private one in cosmwasm-stargate to do the job we need.
| @@ -15,15 +15,15 @@ const rpcUrl = "http://localhost:26659"; | |||
| const prefix = "wasm"; | |||
| const faucet = { | |||
| mnemonic: | |||
| "economy stock theory fatal elder harbor betray wasp final emotion task crumble siren bottom lizard educate guess current outdoor pair theory focus wife stone", | |||
| address0: "wasm1pkptre7fdkl6gfrzlesjjvhxhlc3r4gm32kke3", | |||
| "flat ski gap size ankle rifle congress month nice state follow mechanic produce cube moment boss enlist disorder during logic brother ride erosion member", | |||
There was a problem hiding this comment.
this key has balance
| docker run --rm \ | ||
| --mount type=bind,source="$SCRIPT_DIR/template_v50",target=/root \ | ||
| "$REPOSITORY:$VERSION" \ | ||
| ./setup_wasmd.sh |
There was a problem hiding this comment.
I think we can use generate_template.sh instead of this new script
| @@ -26,7 +26,7 @@ docker run --rm \ | |||
| --name "$CONTAINER_NAME" \ | |||
| -p "$TENDERMINT_PORT_HOST":"$TENDERMINT_PORT_GUEST" \ | |||
| -p "$LCD_API_PORT_HOST":"$LCD_API_PORT_GUEST" \ | |||
| --mount type=bind,source="$SCRIPT_DIR/template",target=/template \ | |||
| --mount type=bind,source="$SCRIPT_DIR/template_v50",target=/template \ | |||
There was a problem hiding this comment.
We can overrise template since we have no way to switch between different wasmd version anyways
|
I'll follow up on your work in #1564. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.