-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(x/tx): API improvements (#15871)
- Loading branch information
1 parent
e3860ac
commit 7041af0
Showing
3 changed files
with
73 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package signing_test | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
|
||
signingv1beta1 "cosmossdk.io/api/cosmos/tx/signing/v1beta1" | ||
"cosmossdk.io/x/tx/signing" | ||
) | ||
|
||
var ( | ||
_ signing.SignModeHandler = directHandler{} | ||
_ signing.SignModeHandler = aminoJSONHandler{} | ||
) | ||
|
||
type directHandler struct{} | ||
|
||
func (s directHandler) Mode() signingv1beta1.SignMode { | ||
return signingv1beta1.SignMode_SIGN_MODE_DIRECT | ||
} | ||
|
||
func (s directHandler) GetSignBytes(_ context.Context, _ signing.SignerData, _ signing.TxData) ([]byte, error) { | ||
panic("not implemented") | ||
} | ||
|
||
type aminoJSONHandler struct{} | ||
|
||
func (s aminoJSONHandler) Mode() signingv1beta1.SignMode { | ||
return signingv1beta1.SignMode_SIGN_MODE_LEGACY_AMINO_JSON | ||
} | ||
|
||
func (s aminoJSONHandler) GetSignBytes(_ context.Context, _ signing.SignerData, _ signing.TxData) ([]byte, error) { | ||
panic("not implemented") | ||
} | ||
|
||
func TestNewHandlerMap(t *testing.T) { | ||
require.PanicsWithValue(t, "nil handler", func() { | ||
signing.NewHandlerMap(nil) | ||
}) | ||
require.PanicsWithValue(t, "no handlers", func() { | ||
signing.NewHandlerMap() | ||
}) | ||
dh := directHandler{} | ||
ah := aminoJSONHandler{} | ||
handlerMap := signing.NewHandlerMap(dh, aminoJSONHandler{}) | ||
require.Equal(t, dh.Mode(), handlerMap.DefaultMode()) | ||
require.NotEqual(t, ah.Mode(), handlerMap.DefaultMode()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters