style: lint v0.45.16-ics-lsm target branch

[faddat]

Description

Closes: #XXXX

Always found linting to be a worthy exercise, especially with tricky bits as it surfaces issues that we might otherwise miss.

This PR is intended to reduce merge conflicts from a linted ics-lsm branch.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

We don’t do extra linting once a release has been tagged. Especially for a version that is is security maintenance mode only. I don’t think this PR is necessary.

[faddat]

I figured you'd feel that way, I'll explain why I'm doing it.

the LSM adds a whole bunch of code, and I'm thinking of this as basically a new mutant branch of the sdk, that likely should be checked carefully, due to the many changes being made. This PR is unfinished, and if we lint here first, then in the changes, there won't be an issue with conflicts.

[julienrbrt]

I agree that the LSM branch should be linted, but only with the linters that are present in the config of that release branch. I don’t think we should and need to modify the config and add more linters.

[faddat]

tests in 45 aren't linted.

There was a good deal of unused code; this is why we lint (plus obsessiveness)

NB: this is not a demand of review or what have you. Feel free to close it. Mainly would feel more comfortable about this hitting the hub if it were extremely neat.