Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add back deleted readmes #17627

Merged
merged 1 commit into from
Sep 5, 2023
Merged

chore: add back deleted readmes #17627

merged 1 commit into from
Sep 5, 2023

Conversation

tac0turtle
Copy link
Member

Description

add back deleted readmes

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title add back readmes chore: add back deleted readmes Sep 5, 2023
@tac0turtle tac0turtle marked this pull request as ready for review September 5, 2023 13:22
@tac0turtle tac0turtle requested a review from a team as a code owner September 5, 2023 13:22
@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 5, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 934abbc Sep 5, 2023
45 of 46 checks passed
@tac0turtle tac0turtle deleted the marko/addbackreadme branch September 5, 2023 13:44
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
@tac0turtle @mergify
chore: add back deleted readmes (#17627)
a0386c1 
(cherry picked from commit 934abbc)

# Conflicts:
#	docs/docs/packages/README.md
#	docs/docs/tooling/README.md
@mergify mergify bot mentioned this pull request Sep 5, 2023
Merged
tac0turtle added a commit that referenced this pull request Sep 5, 2023
@tac0turtle
chore: add back deleted readmes (#17627)
a8f4ae8 
(cherry picked from commit 934abbc)

# Conflicts:
#	docs/docs/packages/README.md
#	docs/docs/tooling/README.md
facundomedica pushed a commit that referenced this pull request Sep 6, 2023
@mergify @tac0turtle
chore: add back deleted readmes (backport #17627) (#17628)
b80ea56 
Co-authored-by: Marko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samricotta samricotta samricotta approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees

@samricotta samricotta

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @samricotta