Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(staking): change historicalinfo to contain minimal set of data #17655

Merged
merged 18 commits into from
Sep 19, 2023
Merged

refactor(staking): change historicalinfo to contain minimal set of data #17655

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
911319f
propose to reduce historicalinfo
tac0turtle Sep 7, 2023
3527963
fix more tests
tac0turtle Sep 7, 2023
46c1138
height -> hash
tac0turtle Sep 7, 2023
5e06fd4
add altvalue codec
tac0turtle Sep 7, 2023
750a213
fix tests
tac0turtle Sep 7, 2023
dd02d36
Merge branch 'main' into marko/reduce_historicalInfo
tac0turtle Sep 18, 2023
a597753
fix tests, lint and add changelog
tac0turtle Sep 18, 2023
21f3935
fix tests
tac0turtle Sep 18, 2023
317580c
fix grpc query test
tac0turtle Sep 18, 2023
5302a41
unbreak proto
tac0turtle Sep 18, 2023
96b8e33
Merge branch 'main' into marko/reduce_historicalInfo
tac0turtle Sep 18, 2023
94bd747
Update proto/cosmos/staking/v1beta1/staking.proto
tac0turtle Sep 18, 2023
9148f74
fix tests
tac0turtle Sep 19, 2023
dc353be
change historical to historical record
tac0turtle Sep 19, 2023
6e9865a
add changelog
tac0turtle Sep 19, 2023
9a33c2e
fix changelog
tac0turtle Sep 19, 2023
2dbf0d0
deprecate message
tac0turtle Sep 19, 2023
e2bf14e
fix lint
tac0turtle Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (x/distribution) [#17115](https://github.com/cosmos/cosmos-sdk/pull/17115) Migrate `PreviousProposer` to collections.
* (x/upgrade) [#16244](https://github.com/cosmos/cosmos-sdk/pull/16244) upgrade module no longer stores the app version but gets and sets the app version stored in the `ParamStore` of baseapp.
* (x/staking) [#17655](https://github.com/cosmos/cosmos-sdk/pull/17655) `HistoricalInfo` was replaced with `Historical`, it removes the validator set and comet header and only keep what is needed for IBC.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the changelog does not correspond to the latest updates in this PR.

Copy link
Member

@julienrbrt julienrbrt Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a Client Breaking change as well, given that the response of the query will be different?


## [v0.50.0-rc.0](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.50.0-rc.0) - 2023-08-18

Expand Down
416 changes: 208 additions & 208 deletions api/cosmos/staking/v1beta1/query.pulsar.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading