fix(store/streaming): reset BlockMetadata between blocks

[kocubinski]

Description

Without this fix block meta data files emitted by the file state streaming grow forever since each successive file contains the txs of all prior blocks. This just resets the tx list between blocks.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Why is this targeting v0.45 given that this version is not maintained and will never be tagged again 🤔

[tac0turtle]

we should point main and then backport to 047+

[kocubinski]

Why is this targeting v0.45 given that this version is not maintained and will never be tagged again 🤔

I targeted 0.45 because gaia is using a (maintained by them?) branch of 0.45.

we should point main and then backport to 047+

I did not target main because the file changed (store/streaming/file/service.go) was deleted prior, I think in 0.47 not sure top of head.

gaia v13 is released with this cosmos-sdk tag right now https://github.com/cosmos/cosmos-sdk/tree/v0.45.16-ics-lsm

I'd like to get this into whatever conception of "trunk" they're using, I assumed it was this branch, but maybe not. How do you think we should proceed?

[julienrbrt]

I'd like to get this into whatever conception of "trunk" they're using, I assumed it was this branch, but maybe not. How do you think we should proceed?

They use another branch (https://github.com/cosmos/cosmos-sdk/tree/feature/v0.45.x-ics-lsm), but their SDK version does not deviate from the deprecated v0.45 sdk except for ics and lsm.
This will be another deviation.

We should only maintain supported releases (v0.46 and v0.47) and let this bug be in v0.45 as it isn't a security bug.