-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baseapp): add per message telemetry #22175
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe changes in the pull request primarily enhance the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@ziscky your pull request is missing a changelog! |
func (app *BaseApp) runMsgs(ctx sdk.Context, msgs []sdk.Msg, reflectMsgs []protoreflect.Message, mode execMode) (*sdk.Result, error) { | ||
events := sdk.EmptyEvents() | ||
msgResponses := make([]*codectypes.Any, 0, len(msgs)) | ||
|
||
// NOTE: GasWanted is determined by the AnteHandler and GasUsed by the GasMeter. | ||
for i, msg := range msgs { | ||
start := telemetry.Now() | ||
|
||
if mode != execModeFinalize && mode != execModeSimulate { | ||
break | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runMsgs (baseapp/baseapp.go:1030)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTx (baseapp/baseapp.go:838)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTx (baseapp/baseapp.go:761)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/baseapp.go:739)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:894)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- baseapp/baseapp.go (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
baseapp/baseapp.go (1)
Pattern
**/*.go
: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (1)
baseapp/baseapp.go (1)
1081-1081
: Approved: Telemetry measurement correctly addedThe
telemetry.MeasureSince
call accurately captures the processing time for each message, aligning with the PR objective to add per-message telemetry. The implementation is appropriate and follows best practices.
// NOTE: GasWanted is determined by the AnteHandler and GasUsed by the GasMeter. | ||
for i, msg := range msgs { | ||
start := telemetry.Now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor: Move start := telemetry.Now()
inside the mode check
The variable start
is only used when mode
is execModeFinalize
or execModeSimulate
. Initializing it before the mode check can lead to unnecessary computations for other modes. Consider moving the initialization inside the if
block to optimize performance.
Suggested change:
- start := telemetry.Now()
if mode != execModeFinalize && mode != execModeSimulate {
break
}
+ start := telemetry.Now()
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
start := telemetry.Now() | |
if mode != execModeFinalize && mode != execModeSimulate { | |
break | |
} | |
start := telemetry.Now() |
Description
Closes: #13981
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes