Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document where source callbacks are executed when forwarding a packet #6883

Closed
bznein opened this issue Jul 18, 2024 · 0 comments · Fixed by #7253
Closed

Document where source callbacks are executed when forwarding a packet #6883

bznein opened this issue Jul 18, 2024 · 0 comments · Fixed by #7253
Assignees
@crodriguezvega
Labels
docs Improvements or additions to documentation
Milestone
v9.0.0

Comments

@bznein
Copy link
Contributor

bznein commented Jul 18, 2024

The full context is here: #6805 (comment)

when forwarding a packet from A -> B -> C, destination callbacks are, as expected, executed on C. However, source callbacks are executed on B while A might seem more intuitive. This needs to be documented properly
@bznein bznein added the docs Improvements or additions to documentation label Jul 18, 2024
@bznein bznein mentioned this issue Jul 18, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Aug 8, 2024
@crodriguezvega crodriguezvega added the needs discussion Issues that need discussion before they can be worked on label Aug 19, 2024
@crodriguezvega crodriguezvega removed the needs discussion Issues that need discussion before they can be worked on label Aug 30, 2024
@crodriguezvega crodriguezvega self-assigned this Sep 2, 2024
@crodriguezvega crodriguezvega linked a pull request Sep 4, 2024 that will close this issue
docs: discourage usage of source callbacks in memo field #7253
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
docs Improvements or additions to documentation
Projects
ibc-go
Status: Done 🥳
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

docs: discourage usage of source callbacks in memo field cosmos/ibc-go
2 participants
@crodriguezvega @bznein