Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: discourage usage of source callbacks in memo field #7253

Merged
merged 4 commits into from
Sep 5, 2024
Merged

docs: discourage usage of source callbacks in memo field #7253

merged 4 commits into from
Sep 5, 2024

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Sep 4, 2024 •
edited
Loading

Description

closes: #7253

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega linked an issue Sep 4, 2024 that may be closed by this pull request
Document where source callbacks are executed when forwarding a packet #6883
Closed
@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Sep 4, 2024
DimitrisJim
DimitrisJim approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crodriguezvega crodriguezvega added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 73061ee Sep 5, 2024
25 of 26 checks passed
@crodriguezvega crodriguezvega deleted the carlos/6883-document-where-source-callbacks-are-executed-when-forwarding-a-packet branch September 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document where source callbacks are executed when forwarding a packet
3 participants
@crodriguezvega @DimitrisJim @colin-axner