chore: expect specific errors in apps/transfer #7205
Conversation
| { | ||
| "invalid trace", | ||
| func() { | ||
| req = &types.QueryDenomHashRequest{ | ||
| Trace: "transfer/channelToA/transfer/", | ||
| Trace: "transfer%%/channel-1/transfer/channel-1/uatom", |
There was a problem hiding this comment.
This test was not triggering the "invalid trace" error but the "denom not found one". Thanks @crodriguezvega for the help!!
There was a problem hiding this comment.
Is the %% what triggers invalid trace here?
There was a problem hiding this comment.
To my understanding yes, but this is all @crodriguezvega!
There was a problem hiding this comment.
Yes, correct. The %% triggers invalid trace error.
| { | ||
| "success", | ||
| func() {}, | ||
| true, |
testing/utils.go
Outdated
| @@ -81,3 +83,12 @@ func UnmarshalMsgResponses(cdc codec.Codec, data []byte, msgs ...codec.ProtoMars | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This was also added in another in-flight PR. There should be no merge conflicts, but I'll take care of them if they arise :)
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
crodriguezvega and
gjermundgaraba
as code owners
| suite.Require().NoError(err) | ||
| suite.Require().NotNil(res) | ||
| suite.Require().Equal(&expDenom, res.Denom) | ||
| } else { | ||
| suite.Require().Error(err) | ||
| ibctesting.RequireErrorIsOrContains(suite.T(), err, tc.expErr, err.Error()) |
There was a problem hiding this comment.
Maybe in a separate PR we should update other tests where this function could be used... More refactoring of tests, yay!!
There was a problem hiding this comment.
Definitely! But I think after these I'll take a break from refactoring tests :D
|
| { | ||
| "invalid trace", | ||
| func() { | ||
| req = &types.QueryDenomHashRequest{ | ||
| Trace: "transfer/channelToA/transfer/", | ||
| Trace: "transfer%%/channel-1/transfer/channel-1/uatom", |
There was a problem hiding this comment.
Is the %% what triggers invalid trace here?
Description
ref: #7175
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.