Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #7208

Merged
merged 1 commit into from
Aug 26, 2024
Merged

chore: fix some comments #7208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/sample.config.extended.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# | RELAYER_ID | The type of relayer to use (rly/hermes) | hermes |


# see sample.config.yaml for a bare minium configuration example.
# see sample.config.yaml for a bare minimum configuration example.
# set env E2E_CONFIG_PATH to point to this file to use it.
---
chains:
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/transfer/ibc_module_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ func (suite *TransferTestSuite) TestOnRecvPacket() {
"success", func() {}, channeltypes.NewResultAcknowledgement([]byte{byte(1)}), "",
},
{
"success: async aknowledgment with forwarding path",
"success: async acknowledgment with forwarding path",
func() {
packetData := types.NewFungibleTokenPacketDataV2(
[]types.Token{
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/transfer/types/packet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func TestFungibleTokenPacketDataValidateBasic(t *testing.T) {
{"valid packet with memo", types.NewFungibleTokenPacketData(denom, amount, sender, receiver, "memo"), true},
{"valid packet with large amount", types.NewFungibleTokenPacketData(denom, largeAmount, sender, receiver, ""), true},
{"invalid denom", types.NewFungibleTokenPacketData("", amount, sender, receiver, ""), false},
{"invalid denom, invalid portID", types.NewFungibleTokenPacketData("(tranfer)/channel-1/uatom", amount, sender, receiver, ""), false},
{"invalid denom, invalid portID", types.NewFungibleTokenPacketData("(transfer)/channel-1/uatom", amount, sender, receiver, ""), false},
{"invalid empty amount", types.NewFungibleTokenPacketData(denom, "", sender, receiver, ""), false},
{"invalid zero amount", types.NewFungibleTokenPacketData(denom, "0", sender, receiver, ""), false},
{"invalid negative amount", types.NewFungibleTokenPacketData(denom, "-1", sender, receiver, ""), false},
Expand Down
4 changes: 2 additions & 2 deletions modules/apps/transfer/types/transfer_authorization_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ func (suite *TypesTestSuite) TestTransferAuthorizationValidateBasic() {
false,
},
{
"fowarding hop with invalid port ID",
"forwarding hop with invalid port ID",
func() {
transferAuthz.Allocations[0].AllowedForwarding = []types.AllowedForwarding{
{Hops: []types.Hop{validHop}},
Expand All @@ -656,7 +656,7 @@ func (suite *TypesTestSuite) TestTransferAuthorizationValidateBasic() {
false,
},
{
"fowarding hop with invalid channel ID",
"forwarding hop with invalid channel ID",
func() {
transferAuthz.Allocations[0].AllowedForwarding = []types.AllowedForwarding{
{Hops: []types.Hop{validHop}},
Expand Down
Loading