chore: remove unused capabilities methods and clean up tests. #7239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
crodriguezvega and
gjermundgaraba
as code owners
colin-axner
reviewed
Sep 3, 2024
| suite.Require().NoError(err) | ||
|
|
||
| cbs, ok := suite.chainA.App.GetIBCKeeper().PortKeeper.Route(module) | ||
| cbs, ok := suite.chainA.App.GetIBCKeeper().PortKeeper.Route(path.EndpointB.ChannelConfig.PortID) |
There was a problem hiding this comment.
Suggested change
| cbs, ok := suite.chainA.App.GetIBCKeeper().PortKeeper.Route(path.EndpointB.ChannelConfig.PortID) | |
| cbs, ok := suite.chainA.App.GetIBCKeeper().PortKeeper.Route(path.EndpointA.ChannelConfig.PortID) |
will tests pass?
There was a problem hiding this comment.
It doesn't because the error message is different... though this is one of the test that I refactored so maybe I put the wrong error msg there. I'll add some more details later
colin-axner
approved these changes
Sep 3, 2024
DimitrisJim
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
lgtm! we should probably keep track of public functions removed in order to specify them by name in the migration docs/changelog. I.e LookupModuleByChannel/ChannelCapabilityPath. This might make the doc writeup for the changes easier to do.
Echoing the sentiment on the beautiful split up of this removal!
damiannolan
approved these changes
Sep 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.