chore: add MsgSendPacket #7254
Merged
chore: add MsgSendPacket #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
commented
Sep 5, 2024
|
|
||
| ctx := suite.chainA.GetContext() | ||
|
|
||
| if tc.expPanic != "" { | ||
| suite.PanicsWithValue(tc.expPanic, func() { suite.chainA.App.GetIBCKeeper().Acknowledgement(ctx, msg) }) //nolint |
There was a problem hiding this comment.
The linter here complains that the error returned is not checked. But we want the function to panic so there's no reason to complicate the code by checking for an error
|
Opening this up as "ready" just to verify that E2E pass. Not ready for review yet |
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan,
chatton,
DimitrisJim,
crodriguezvega and
gjermundgaraba
as code owners
10 tasks
bznein
commented
Sep 10, 2024
| //sdk.NewAttribute(types.AttributeKeyDataHex, hex.EncodeToString(packet.GetData())), TODO | ||
| // sdk.NewAttribute(types.AttributeKeyDataHex, hex.EncodeToString(packet.GetData())), TODO |
There was a problem hiding this comment.
A lot of changes like these unfortunately caused by the linter :(
damiannolan
approved these changes
Sep 10, 2024
| @@ -86,5 +87,17 @@ func (k *Keeper) LookupModuleByPort(ctx sdk.Context, portID string) (string, *ca | |||
| // Route returns a IBCModule for a given module, and a boolean indicating | |||
| // whether or not the route is present. | |||
| func (k *Keeper) Route(module string) (types.IBCModule, bool) { | |||
| return k.Router.GetRoute(module) | |||
| routes, ok := k.Router.GetRoute(module) | |||
| } | ||
|
|
||
| for _, prefix := range k.Router.Keys() { | ||
| if strings.Contains(module, prefix) { |
There was a problem hiding this comment.
I think we should use HasPrefix here rather than doing a contains
|
Will address the comments when I handle the merge conflicts from #7238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Huge diff but:
Almost 900 added lines are auto-generated proto stuff
a couple of files have been brought in by #7238
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.