api!: remove capabilities #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
commented
Sep 10, 2024
| @@ -65,16 +64,7 @@ func (k Keeper) registerInterchainAccount(ctx context.Context, connectionID, por | |||
| return "", errorsmod.Wrapf(icatypes.ErrActiveChannelAlreadySet, "existing active channel %s for portID %s on connection %s", activeChannelID, portID, connectionID) | |||
| } | |||
|
|
|||
| switch { | |||
| case k.portKeeper.IsBound(ctx, portID) && !k.hasCapability(ctx, portID): | |||
There was a problem hiding this comment.
This case basically says - if a a capability exists (port is bound) with core ibc, but not claimed by the ica app, then return an error. This is essentially unreachable code, unless someone has wired a code path into the chain to allow icacontroller- port ids to be created with the core ibc scoped keeper.
| switch { | ||
| case k.portKeeper.IsBound(ctx, portID) && !k.hasCapability(ctx, portID): | ||
| return "", errorsmod.Wrapf(icatypes.ErrPortAlreadyBound, "another module has claimed capability for and bound port with portID: %s", portID) | ||
| case !k.portKeeper.IsBound(ctx, portID): |
There was a problem hiding this comment.
This case is - if no capability exists (port bound) for port id in core ibc's scoped keeper, then;
- Set port: this was previously used for genesis exports such that we can recreate ports on a genesis restart, unclear if we still actually need this for ica as ports are assumed to be in the format
icacontroller-. Unlike transfer where we set the port because it could be modified by devs to e.g. "ibc-transfer" (unclear if there is assumptions in other places that it must just be "transfer"). - Create a new capability via
BindPortusing ibc core's scoped keeper. This creates a capability and adds "ibc" as an owner. - Claim the capability using the ica scoped keeper. This adds ica as the second owner
In scenarios where we open a new channel(after close) for an existing port id, then neither of these cases are hit and skip the entire switch statement.
damiannolan
requested review from
colin-axner,
AdityaSripal,
srdtrk,
chatton,
DimitrisJim,
crodriguezvega,
gjermundgaraba and
bznein
as code owners
chatton
approved these changes
Sep 10, 2024
bznein
approved these changes
Sep 10, 2024
DimitrisJim
approved these changes
Sep 10, 2024
| @@ -19,7 +19,6 @@ require ( | |||
| github.com/cosmos/cosmos-proto v1.0.0-beta.5 | |||
| github.com/cosmos/cosmos-sdk v0.50.10-0.20240808075341-156231be8aef | |||
| github.com/cosmos/gogoproto v1.7.0 | |||
| github.com/cosmos/ibc-go/modules/capability v1.0.1 | |||
|
colin-axner
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.